[PATCH] D158326: [RISCV] Separate hasRoundModeOpNum into separate VXRM and FRM functions.

[Yueh-Ting (eop) Chen via Phabricator via llvm-commits]

eopXD added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:782
+  if (RISCVII::hasVLOp(TSFlags))
+    --NumOps;
   if (RISCVII::hasRoundModeOp(TSFlags))
----------------
craig.topper wrote:
> eopXD wrote:
> > Nit Looks like this is redundant change here?
> I put them in the reverse order the operands appear on instructions. That way each time we decrement NumOps we are effectively removing the operand we're checking for.
I see. Thank you for explaining.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158326/new/

https://reviews.llvm.org/D158326