[PATCH] D158326: [RISCV] Separate hasRoundModeOpNum into separate VXRM and FRM functions.

[Yueh-Ting (eop) Chen via Phabricator via llvm-commits]

eopXD added a comment.

IIUC, this patch will not introduce functional changes and is refactoring so future CSR insertion algorithm can be done cleanly.
Other than nits, the patch looks good to me.



================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:216
+  // | n-1 (if any)   | n-2  | n-3 | n-4 |
+  // | policy         | sew  | vl  | rm  |
+  // -------------------------------------
----------------
nit: `| policy         | sew  | vl  | frm  |`


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:230
+  // | n-1 (if any)   | n-2  | n-3 | n-4 |
+  // | policy         | sew  | vl  | rm  |
+  // -------------------------------------
----------------
nit: `| policy         | sew  | vl  | vxrm  |`


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:782
+  if (RISCVII::hasVLOp(TSFlags))
+    --NumOps;
   if (RISCVII::hasRoundModeOp(TSFlags))
----------------
Nit Looks like this is redundant change here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158326/new/

https://reviews.llvm.org/D158326