[PATCH] D158328: [PowerPC] Merge rotate and clear into single instruction.

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5103
+
+  if (Val.getOperand(1).getOpcode() == ISD::Constant)
+    return false;
----------------
Why does this need to be constant?


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-rotate-clear.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
+; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff -mcpu=pwr8 \
----------------
Please pre-commit the test case so this patch only shows the differences in code generation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158328/new/

https://reviews.llvm.org/D158328