[PATCH] D158197: [PowerPC][lld] Account for additional X-Forms -> D-Form/DS-Forms load/stores when relaxing initial-exec to local-exec
Amy Kwan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 19 22:21:59 PDT 2023
amyk added a comment.
I've addressed all of the current comments, with the exception of Nemanja's comment on using a different mask for the DS-Form case (since we're still currently discussing that).
================
Comment at: lld/ELF/Arch/PPC64.cpp:855
+ default:
+ return 1;
+ }
----------------
MaskRay wrote:
> amyk wrote:
> > nemanjai wrote:
> > > I forgot to mention it yesterday, but I don't think we should have a different signal for failure here (i.e. returning 1 instead of 0 like in `getPPCDFormOp()`). Let's just use zero for both.
> > I will update this.
> Mark as unresolved.
Thank you for pointing that out. I have now updated the patch, so the comment should be resolved.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158197/new/
https://reviews.llvm.org/D158197
More information about the llvm-commits
mailing list