[PATCH] D158272: [AArch64] [GlobalISel] Fix clobbered callee saved registers with win64 varargs

Sat Aug 19 15:03:04 PDT 2023

mstorsjo added a comment.

In D158272#4600549 <https://reviews.llvm.org/D158272#4600549>, @dzhidzhoev wrote:

> Looks good to me

Thanks! Would you care to set the formal approval flag as well? (I'd like to get this landed so I can flag it for backporting soon - this can cause subtle breakage for any vararg function on windows/aarch64, if compiled without optimizations.)

For context; D130903 <https://reviews.llvm.org/D130903> ported a bunch of logic from SelectionDAG to GlobalISel, but skipped these lines as they were believed to not be necessary - but they turned out to be needed after all. This patch readds the few lines that were skipped. (They have been in place in the SelectionDAG implementation since 2017.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158272/new/

https://reviews.llvm.org/D158272