[PATCH] D156505: [AArch64][ELF] Support R_AARCH64_AUTH_ABS64 static relocation

Sat Aug 19 14:59:00 PDT 2023

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D156505#4599128 <https://reviews.llvm.org/D156505#4599128>, @kovdan01 wrote:

> TODO: add more unary/binary operator tests like `1 + sym at AUTH(ia,42) + 1`, `sym at AUTH(ia,0) + sym at AUTH(ia,0)`.

Yes, we should add the coverage, otherwise this looks good to me.

================
Comment at: llvm/docs/PointerAuth.md:308
+[Authenticated Relocations](#authenticated-global-relocation) are represented
+using the ``@AUTH`` modifier:
+
----------------
kovdan01 wrote:
> MaskRay wrote:
> > This file is a Markdown. Single backquotes are more commonly used.
> I agree with that, but double backquotes are already used in other places in this file.
> I suggest to leave this 'as is' in context of current patch and submit a small subsequent patch changing double- to single backquote all over the file.
Adding double quotes than applying another patch changing double quotes to single quotes is not a good idea.
We can add single quotes directly.

The existing places can be fixed separately. I shall also mention that `.rst` is more commonly used and helps cross-doc links.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156505/new/

https://reviews.llvm.org/D156505