[PATCH] D158217: [NFCi][MergeFunctions] Consolidate Hashing Functions

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 19 03:43:52 PDT 2023


mgorny added a comment.

This change has caused a test regression on 32-bit hosts (reproduced on ARM and x86):

  FAIL: LLVM :: Transforms/MergeFunc/inline-asm.ll (14 of 62)
  ******************** TEST 'LLVM :: Transforms/MergeFunc/inline-asm.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /home/mgorny/llvm-project/build/bin/opt -passes=mergefunc -S < /home/mgorny/llvm-project/llvm/test/Transforms/MergeFunc/inline-asm.ll | /home/mgorny/llvm-project/build/bin/FileCheck /home/mgorny/llvm-project/llvm/test/Transforms/MergeFunc/inline-asm.ll
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/mgorny/llvm-project/llvm/test/Transforms/MergeFunc/inline-asm.ll:9:16: error: CHECK-LABEL: expected string not found in input
  ; CHECK-LABEL: @int_ptr_arg_same
                 ^
  <stdin>:35:26: note: scanning from here
  define void @int_ptr_null() {
                           ^
  <stdin>:36:19: note: possible intended match here
   tail call void @float_ptr_null()
                    ^
  
  Input file: <stdin>
  Check file: /home/mgorny/llvm-project/llvm/test/Transforms/MergeFunc/inline-asm.ll
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
             .
             .
             .
            30: define void @int_ptr_arg_same(ptr %0) { 
            31:  tail call void @float_ptr_arg_same(ptr %0) 
            32:  ret void 
            33: } 
            34:  
            35: define void @int_ptr_null() { 
  label:9'0                              X~~~~ error: no match found
            36:  tail call void @float_ptr_null() 
  label:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  label:9'1                       ?                possible intended match
            37:  ret void 
  label:9'0     ~~~~~~~~~~
            38: } 
  label:9'0     ~~
  >>>>>>
  
  --

FWICS the functions are now output in different order depending on the arch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158217/new/

https://reviews.llvm.org/D158217



More information about the llvm-commits mailing list