[PATCH] D158324: Revert "[RegisterCoalescing] Don't move COPY if it would interfere with another value"

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 17:29:47 PDT 2023


arsenm added a comment.

In D158324#4600553 <https://reviews.llvm.org/D158324#4600553>, @bjope wrote:

> One thing I don't fully understand is that the description says that the test case was wrong and did not pass verification. But you've also reverted the code and not only changed the test case.
>
> But I figure the modified test case would pass both with and without the code changes.

It does

> So do you want to revert the code changes as well since there is no motivating test case?

That is what this does

> If so it would be nice to say something in the commit message about that (that the code is reverted even if there is no proof that it was incorrect?).

Not sure what you mean, if you add -verify-coalescing to the test it fails.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158324/new/

https://reviews.llvm.org/D158324



More information about the llvm-commits mailing list