[PATCH] D116993: [M68k] Add MC support for bchg, bclr and bset instruction

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.

LGTM with minor issues, thanks!



================
Comment at: llvm/lib/Target/M68k/M68kInstrBits.td:63
+    : MxInst<(outs), (ins TYPE.ROp:$dst, TYPE.ROp:$bitno),
+             MN#"\t$bitno, $dst", []> {
+  let Inst = MxBITEnc_R<OPMODE, MxEncAddrMode_r<"dst">, "bitno">.Value;
----------------
nit: ISel pattern is initialized to empty list by default so you don't need to put a `[]` here. Ditto for other places in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116993/new/

https://reviews.llvm.org/D116993