[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests
Han Shen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 18 14:14:02 PDT 2023
shenhan accepted this revision.
shenhan added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:72
+static cl::opt<bool> AllowUnsupportedTriple(
+ "mfs-split-unsupported-triple",
+ cl::desc(
----------------
nit: "mfs" already contains "split", so mfs-split-xxx seems a little bit redundant. "mfs-allow-unsupported-triple" seems more aligned with the variable name.
================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:150
UnsupportedTriple = true;
- M.getContext().diagnose(
- DiagnosticInfoMachineFunctionSplit(T, DS_Warning));
+ M.getContext().diagnose(DiagnosticInfoMachineFunctionSplit(T, DS_Warning));
return false;
----------------
Thanks for fixing the format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157565/new/
https://reviews.llvm.org/D157565
More information about the llvm-commits
mailing list