[PATCH] D158246: [amdgpu] WIP variadics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/DesugarVariadics.cpp:296
+    // Note - same attribute handling as DeadArgumentElimination
+    NF->copyAttributesFrom(&F);
+    NF->setComdat(F.getComdat());
----------------
This might be missing copying the linkage


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158246/new/

https://reviews.llvm.org/D158246