[PATCH] D158280: [jitlink/rtdydl][checker] Construct disassembler at every decodeInst

[Eymen Ünay via Phabricator via llvm-commits]

Eymay added a comment.

In D158280#4599171 <https://reviews.llvm.org/D158280#4599171>, @lhames wrote:

> What if you made `RuntimeDyldChecker::getInstPrinter` and `RuntimeDyld::getDisasssembler` take a symbol, then check the target flags in each of those methods so that the callees reduce back to, e.g.
>
>   auto Dis = Checker.getDisassembler(Symbol); // TT and TF taken from Checker member variables.
>   
>   if (auto E = Dis.takeError()) {
>     errs() << "Error obtaining disassembler: " << toString(std::move(E))
>            << "\n";
>     return false; // Return false or take appropriate action.
>   }

Thanks for the feedback! It makes sense, moved handling into the getters. Also added getTripleFromTargetFlag function. Now, targets can handle their TargetFlag--Triple mappings inside there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158280/new/

https://reviews.llvm.org/D158280