[PATCH] D158102: APFloat: Add getExactLog2Abs

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 10:55:50 PDT 2023


sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/include/llvm/ADT/APFloat.h:500
   LLVM_READONLY
-  int getExactLog2() const;
+  inline int getExactLog2() const {
+    return isNegative() ? INT_MIN : getExactLog2Abs();
----------------
`inline` is excessive here, a member function defined in its class definition is inline (https://eel.is/c++draft/class.mfct#1).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158102/new/

https://reviews.llvm.org/D158102



More information about the llvm-commits mailing list