[PATCH] D158053: [Legalizer] Expand fmaximum and fminimum

Evgenii Kudriashov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 09:07:13 PDT 2023


e-kud added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:8183
+    SDValue Pos1 = DAG.getSelect(DL, VT, Neg0Pos1, IsMax ? RHS : LHS, Pos0);
+    MinMax = DAG.getSelect(DL, VT, IsZero, Pos1, MinMax);
+  }
----------------
Could it be simplified for `maximum` as follows?

```
Tmp = select(is_fpclass(PosZero, LHS), LHS, MinMax)
Res = select(is_fpclass(PosZero, RHS), RHS, Tmp)
MinMax = select(IsZero, Res, MinMax)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158053/new/

https://reviews.llvm.org/D158053



More information about the llvm-commits mailing list