[PATCH] D158256: [RISCV] Fix assertion failure when zcmp extension is enabled.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/prolog-epilog-crash.mir:7
+--- |
+  define hidden void @f(fp128 %a) local_unnamed_addr #0 {
+  entry:
----------------
garvitgupta08 wrote:
> garvitgupta08 wrote:
> > jrtc27 wrote:
> > > Is the IR actually needed?
> > Yes, I think that is how it has been done what other mir unit test cases. Besides it would help to see the .ll file from which the mir testcase is generated.
> There is a typo - //for// other mir unit testcases.
Not all MIR tests need it. So I'm asking whether this one specifically does.


================
Comment at: llvm/test/CodeGen/RISCV/prolog-epilog-crash.mir:35
+---
+name:            f
+alignment:       2
----------------
garvitgupta08 wrote:
> jrtc27 wrote:
> > If you're going to call it `f` then the test needs a comment for what's being tested here
> It it the reduced testcase through bugpoint which tests the prologepilog pass. 
So? bugpoint reduces it, but you still need to turn it into a meaningful and readable test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158256/new/

https://reviews.llvm.org/D158256