[PATCH] D157495: [WIP] Run SimplifyCFG from Atomic-Expand on CAS loop blocks.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D157495#4598715 <https://reviews.llvm.org/D157495#4598715>, @pravinjagtap wrote:

> In D157495#4598667 <https://reviews.llvm.org/D157495#4598667>, @arsenm wrote:
>
>> In D157495#4598420 <https://reviews.llvm.org/D157495#4598420>, @pravinjagtap wrote:
>>
>>> addressed review comment
>>
>> Haven't tried to delete the AArch64 atomic tidy?
>
> TBH, I am not sure how to exactly achieve this.

Delete the option and run of the pass and see if it's equivalently effective in the existing tests to this



================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:116
+      CreateCmpXchgInstFun CreateCmpXchg,
+      SmallVector<BasicBlock *> &CmpXchgLoopBlocks);
   bool tryExpandAtomicCmpXchg(AtomicCmpXchgInst *CI);
----------------
pravinjagtap wrote:
> arsenm wrote:
> > Do you need to track this or can you just clean each one up as it happens?
> > Do you need to track this or can you just clean each one up as it happens?
> 
> I am clearing this vector at the beginning itself in runOnFunction 
That's not what I meant, I mean you performed the expansion and can immediately simplify the block without recording it and treating it like a separate pass


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157495/new/

https://reviews.llvm.org/D157495