[PATCH] D156301: [AMDGPU] Support FAdd/FSub global atomics in AMDGPUAtomicOptimizer.
Pravin Jagtap via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 18 06:04:35 PDT 2023
pravinjagtap added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:397
for (unsigned Idx = 0; Idx < 4; Idx++) {
- V = buildNonAtomicBinOp(
- B, Op, V,
- B.CreateCall(UpdateDPP,
- {Identity, V, B.getInt32(DPP::ROW_XMASK0 | 1 << Idx),
- B.getInt32(0xf), B.getInt32(0xf), B.getFalse()}));
+ V = B.CreateBitCast(V, IntNTy);
+ Value *UpdateDPPCall = B.CreateCall(
----------------
arsenm wrote:
> Do you want to switch to the float overloads for the DPP intrinsic here or in a follow up?
I would prefer in follow up patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156301/new/
https://reviews.llvm.org/D156301
More information about the llvm-commits
mailing list