[PATCH] D157495: [WIP] Run SimplifyCFG from Atomic-Expand on CAS loop blocks.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D157495#4598420 <https://reviews.llvm.org/D157495#4598420>, @pravinjagtap wrote:

> addressed review comment

Haven't tried to delete the AArch64 atomic tidy?



================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:116
+      CreateCmpXchgInstFun CreateCmpXchg,
+      SmallVector<BasicBlock *> &CmpXchgLoopBlocks);
   bool tryExpandAtomicCmpXchg(AtomicCmpXchgInst *CI);
----------------
Do you need to track this or can you just clean each one up as it happens?


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:361
+  for (BasicBlock *BB : CmpXchgLoopBlocks) {
+    simplifyCFG(BB, *TTI, RequireAndPreserveDomTree ? &DTU : nullptr,
+                SimplifyCFGOptions()
----------------
Why is RequireAndPreserveDomTree a cl:opt?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157495/new/

https://reviews.llvm.org/D157495