[PATCH] D158234: [MLIR][Math] Add support for f16 in the expansion of math.roundeven
David Spickett via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 18 05:41:13 PDT 2023
DavidSpickett added a comment.
> @DavidSpickett - thanks a lot, I'd like to clarify - is this version also failing on windows arm (if you happen to know) ?
I haven't gone to reproduce it yet.
> (the previous one contained an issue with dllexport/dllimport - the final output could have been mislinked)
Now you mention it the assert comes from some kind of relocation. Ignore what I said about `UNSUPPORTED` and go ahead and land it. It could very well be fixed now, I did find it strange that it wouldn't build on x86 but did on Arm.
If it fails again I'll disable it and investigate.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158234/new/
https://reviews.llvm.org/D158234
More information about the llvm-commits
mailing list