[PATCH] D157811: [DAGCombiner] Don't merge stores to an illegal integer type

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/merge_stores_post_legalization_crash.ll:16
+%arrayidx = getelementptr inbounds i64, i64* %arr1, i64 2
+%0 = load i64, i64* %arrayidx, align 8
+store i64 %0, i64* %arr1, align 8
----------------
arsenm wrote:
> Test should use opaque pointers 
Ah, good point. This was added to the bug report before the switch. I'll update it.


================
Comment at: llvm/test/CodeGen/PowerPC/merge_stores_post_legalization_crash.ll:25
+
+define dso_local void @test_vec(i64* nocapture %arr1) local_unnamed_addr {
+; CHECK-LABEL: test_vec:
----------------
arsenm wrote:
> Can drop attributes and local_unnamed_addr
I kept the attributes on one version so we can test the `noimplicitfloat` and a regular one in two functions within the same invocation of `llc`. Would you prefer that I just have one function with no attributes and just use two RUN lines?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157811/new/

https://reviews.llvm.org/D157811