[PATCH] D158256: [RISCV] Fix assertion failure when zcmp extension is enabled.

garvit gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 03:00:51 PDT 2023


garvitgupta08 marked 4 inline comments as done.
garvitgupta08 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/prolog-epilog-crash.mir:7
+--- |
+  define hidden void @f(fp128 %a) local_unnamed_addr #0 {
+  entry:
----------------
jrtc27 wrote:
> Is the IR actually needed?
Yes, I think that is how it has been done what other mir unit test cases. Besides it would help to see the .ll file from which the mir testcase is generated.


================
Comment at: llvm/test/CodeGen/RISCV/prolog-epilog-crash.mir:35
+---
+name:            f
+alignment:       2
----------------
jrtc27 wrote:
> If you're going to call it `f` then the test needs a comment for what's being tested here
It it the reduced testcase through bugpoint which tests the prologepilog pass. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158256/new/

https://reviews.llvm.org/D158256



More information about the llvm-commits mailing list