[PATCH] D158262: [AArch64] Add Defs=[NZCV] to MTE loop pseudos.

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/memtag-loop-nzcv.ll:1
+; RUN: llc -O2 -print-after-isel -mtriple=aarch64-linux-gnu %s -o /dev/null 2> %t; FileCheck %s --check-prefixes=CHECK < %t
+
----------------
Any reason not to do the usual `... | FileCheck %s ...`?


================
Comment at: llvm/test/CodeGen/AArch64/memtag-loop-nzcv.ll:9
+; that's not a problem. The important thing is that both should
+; include that implicit-def of $nzcv.
+
----------------
Add the reason here? `of $nzcv because...`


================
Comment at: llvm/test/CodeGen/AArch64/memtag-loop-nzcv.ll:14
+
+target triple = "aarch64-unknown-linux-gnu"
+
----------------
Might not be needed due to `-mtriple` above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158262/new/

https://reviews.llvm.org/D158262