[PATCH] D158164: [FileCheck] Added --match-full-lines-leading and --match-full-lines-trailing option

[James Henderson via Phabricator via llvm-commits]

jhenderson added reviewers: jdenny, thopre.
jhenderson added a subscriber: jdenny.
jhenderson added a comment.

In D158164#4595420 <https://reviews.llvm.org/D158164#4595420>, @strimo378 wrote:

> --match-full-lines is require to check that nothing trailing is missing. Current approach is to add in 100 lines {{$}}

Okay, I think I see your point. You are simply looking to find a way to apply that regex pattern to every line, much like `--match-full-lines` adds an implicit `{{^}}` and `{{$}}` around each line. Is that correct? And you don't want to use `--match-full-lines` because of the noisy prefixes (hence I'm not sure @MaskRay's suggestion will work).

I'm not strongly opposed to the new options. However, they should be a) documented, and b) I think the names are wrong, since they contradict themselves - trailing only means not "full-lines". I would suggest that the names might be `--match-leading-lines` and `--match-trailing-lines` or something to that effect.

@jdenny/@thopre, any thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158164/new/

https://reviews.llvm.org/D158164