[PATCH] D82525: [FPEnv] Intrinsics for access to FP control modes

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 00:00:45 PDT 2023


sepavloff added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4845
+        Node->getOperand(0), dl, Mode, StackPtr,
+        MachinePointerInfo::getFixedStack(DAG.getMachineFunction(), SPFI));
+    Results.push_back(
----------------
arsenm wrote:
> This should be getStack, not getFixedStack
Could you please explain a bit, why it should be `getStack`? It is not used anywhere in this file. Function `PerformInsertVectorEltInMemory` uses `getFixedStack` for temporary space, what is the difference between it and these cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82525/new/

https://reviews.llvm.org/D82525



More information about the llvm-commits mailing list