[PATCH] D158169: [X86] Fix i128 argument passing under SysV ABI

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 22:53:55 PDT 2023


pengfei added a comment.

In D158169#4597602 <https://reviews.llvm.org/D158169#4597602>, @craig.topper wrote:

> In D158169#4597591 <https://reviews.llvm.org/D158169#4597591>, @pengfei wrote:
>
>> Do we have a way to detect it's from `i128` and only do for it? I think we will increase unnecessary load/stores to normal 64-bit argument passing which would be more common in practice.
>
> I think the CCIfSplit means it was larger than i64 to start.

That's great! Thanks Craig!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158169/new/

https://reviews.llvm.org/D158169



More information about the llvm-commits mailing list