[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D158067#4597654 <https://reviews.llvm.org/D158067#4597654>, @4vtomat wrote:

> In D158067#4592569 <https://reviews.llvm.org/D158067#4592569>, @craig.topper wrote:
>
>> Should Zvkb and Zvbb be in this list?
>>
>>   void RISCVIntrinsicManagerImpl::ConstructRVVIntrinsics(                          
>>       ArrayRef<RVVIntrinsicRecord> Recs, IntrinsicKind K) {                        
>>     const TargetInfo &TI = Context.getTargetInfo();                                
>>     static const std::pair<const char *, uint8_t> FeatureCheckList[] = {           
>>         {"64bit", RVV_REQ_RV64},                                                   
>>         {"xsfvcp", RVV_REQ_Xsfvcp}}; 
>
> If we add `Zvkb` and `Zvbb` to the list, we should also add other vector crypto extensions to the list right?

Yes. Should be a different patch I suppose


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158067/new/

https://reviews.llvm.org/D158067