[PATCH] D127994: [AMDGPU] Expose CLI controls for IGroup ordering

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.
Herald added a subscriber: wangpc.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:79-98
+    if (Token == "alu")
+      return SchedGroupMask::ALU;
+    else if (Token == "valu")
+      return SchedGroupMask::VALU;
+    else if (Token == "salu")
+      return SchedGroupMask::SALU;
+    else if (Token == "mfma")
----------------
Use StringSwitch


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:211-220
+static cl::list<std::string,
+                SmallVector<std::pair<SchedGroupMask, Optional<unsigned>>, 8>,
+                IGroupOrderParser>
+    List("amdgpu-igrouplp-order",
+         cl::desc("This option is used to specify the order of groups and "
+                  "their sizes to be used in AMDGPUIGroupLP. To specify, "
+                  "enter a comma seperated list of groups in {salu, valu, "
----------------
Who is intended to use this? Users aren't supposed to be exposed to cl::opts like this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127994/new/

https://reviews.llvm.org/D127994