[PATCH] D137937: [TableGen] Represent IntrHasSideEffects using inaccessiblemem read+write

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 15:27:17 PDT 2023


arsenm added a comment.
Herald added a subscriber: StephenFan.

mayLoad and mayStore should be set to 0 for barriers. Setting either to one implies there should be a memory operand, which is not the case.

CodeGen has the explicit hasSideEffects for unmodeled / nonmemory side effects unlike the IR. If TableGen is complaining about requiring mayLoad/mayStore here, then that's a tablegen bug. IntrHasSideEffects should be enough to cover this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137937/new/

https://reviews.llvm.org/D137937



More information about the llvm-commits mailing list