[PATCH] D155732: [MC][COFF][AArch64] Avoid incorrect IMAGE_REL_ARM64_BRANCH26 relocations.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

hjyamauchi added inline comments.


================
Comment at: llvm/test/MC/AArch64/coff-relocations-branch26-bad.s:1
+// RUN: not llvm-mc -triple aarch64-unknown-windows-msvc -filetype obj %s -o /dev/null 2>&1 | FileCheck %s
+
----------------
MaskRay wrote:
> In many occasions placing negative tests in the same file as the positive tests improves readability. You can use the `--defsym ERR=1` pattern
Done.


================
Comment at: llvm/test/MC/AArch64/coff-relocations-branch26-bad.s:18
+
+// CHECK: error: cannot perform a PC-relative fixup with a non-zero symbol offset
----------------
MaskRay wrote:
> New tests are recommended to add line/column information to diagnostics, similar to `test/MC/ELF/cfi-scope-errors.s`
Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155732/new/

https://reviews.llvm.org/D155732