[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:73
+// function splitting is fully enabled on AArch64.
+static cl::opt<bool> IgnoreTripleForDebug(
+    "mfs-ignore-triple",
----------------
dhoekwater wrote:
> rahmanl wrote:
> > How about introducing a permanent option named `SkipUnsupportedTriple` and default it True so we can use it for any future architectures?
> I'm onboard with making this a permanent flag for testing purposes only, but I'm not sure about inverting and defaulting to true. Isn't it standard to have default-false hidden flags that enable some special behavior (as opposed to default-true hidden flags that enable the default behavior)?
> 
> For example, most of the `cl::opt<bool>` options in `llvm/lib/Analysis/InlineCost.cpp` follow this pattern.
Up to you. I thought this naming better matches with the current code (`UnsupportedTriple` and `isSupportedTriple`). `Ignore` doesn't fully convey what the flag actually does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157565/new/

https://reviews.llvm.org/D157565