[PATCH] D139750: Optionally print symbolizer markup backtraces.

Thu Aug 17 12:43:22 PDT 2023

mysterymath added a comment.

In D139750#4596368 <https://reviews.llvm.org/D139750#4596368>, @arphaman wrote:

> This breaks the build on Darwin: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/37054/:
>
>   Undefined symbols for architecture x86_64:
>     "printMarkupContext(llvm::raw_ostream&, char const*)", referenced from:
>         printMarkupStackTrace(llvm::StringRef, void**, int, llvm::raw_ostream&) in libLLVMSupport.a(Signals.cpp.o)
>
> @mysterymath could you take a look please?

Ah, thanks, both of these real oversights. Missing stub for the Darwin path, and overly-restrictive regex for the Linux case. I'll have a fix out in an hour or so; if that's too late, feel free to revert.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139750/new/

https://reviews.llvm.org/D139750