[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added inline comments.


================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:294
+        continue;
+      NopInstr.addOperand(
+          MachineOperand::CreateImm(Nop.getOperand(0).getImm()));
----------------
Is this because of ARM? Maybe add a comment to explain the rationale.


================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:73
+// function splitting is fully enabled on AArch64.
+static cl::opt<bool> IgnoreTripleForDebug(
+    "mfs-ignore-triple",
----------------
How about introducing a permanent option named `SkipUnsupportedTriple` and default it True so we can use it for any future architectures?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157565/new/

https://reviews.llvm.org/D157565