[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests

Daniel Hoekwater via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 11:31:22 PDT 2023


dhoekwater created this revision.
dhoekwater added reviewers: snehasish, shenhan, xur, wenlei.
Herald added subscribers: pengfei, kristof.beyls.
Herald added a project: All.
dhoekwater edited the summary of this revision.
dhoekwater updated this revision to Diff 551202.
dhoekwater added a comment.
Herald added a subscriber: hiraditya.
dhoekwater edited reviewers, added: rahmanl; removed: snehasish, xur.
dhoekwater edited the summary of this revision.
dhoekwater edited the summary of this revision.
dhoekwater retitled this revision from "[CodeGen] Add AArch64 behavior to existing MFS tests (NFC)" to "[CodeGen] Add AArch64 behavior to existing MFS tests".
dhoekwater edited the summary of this revision.
dhoekwater published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Rebase onto other MFS tests and fix the BBsections code that makes the test crash


X86 and AArch64 have some small differences in output because of non-MFS
factors (such as encoding function calls as `callq` vs `bl`). Add
AArch64 checks for tests where output varies between platforms even
if MFS logic doesn't. Add a debug flag to run MFS on any target.
Fix the encoding of nops in bbsections.

Without this change, there is no way to test that MFS functions correctly on AArch64.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157565

Files:
  llvm/lib/CodeGen/BasicBlockSections.cpp
  llvm/lib/CodeGen/MachineFunctionSplitter.cpp
  llvm/test/CodeGen/Generic/machine-function-splitter.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157565.551202.patch
Type: text/x-patch
Size: 8899 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230817/a36efa30/attachment.bin>


More information about the llvm-commits mailing list