[PATCH] D157020: [WIP][lld/ELF] Don't relax R_X86_64_(REX_)GOTPCRELX when offset is too far

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 11:27:48 PDT 2023


aeubanks added inline comments.


================
Comment at: lld/ELF/Arch/X86_64.cpp:318
+  // overflow.
+  if (maxVA - minVA < (uint64_t(1) << 31) - 1)
+    return false;
----------------
@MaskRay is this ok performance wise? this should be very quick and we should skip the expensive stuff below for typical binaries


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157020/new/

https://reviews.llvm.org/D157020



More information about the llvm-commits mailing list