[PATCH] D158185: [DebugInfo] Process single-location debug values in variadic form when producing DWARF

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 10:01:50 PDT 2023


StephenTozer updated this revision to Diff 551178.
StephenTozer added a comment.

Patch broke a test case, which tested that we don't emit locations for dbg.values with constant operands >64 bits as part of a normal DWARF expression, which was appearing in variadic dbg.values. This patch incidentally fixes the //specific// test by causing the example variadic expression to be interpreted as non-variadic, but slightly modifying the expression fixes that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158185/new/

https://reviews.llvm.org/D158185

Files:
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/test/DebugInfo/X86/debug-value-list-entry-value.mir
  llvm/test/DebugInfo/X86/pr52584.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158185.551178.patch
Type: text/x-patch
Size: 16252 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230817/aa12125f/attachment.bin>


More information about the llvm-commits mailing list