[PATCH] D158171: [instcombine] Sunk instruction introduces unnecessary poison dbg.value

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3863
+  // found by 'findDbgUsers'. If that is the case, those debug variables
+  // must be preserved from any salvage debug use.
+  SmallVector<DbgVariableIntrinsic *, 2> DbgUsersToSalvage;
----------------
Looking at the testcase, this seems good, I just have trouble parsing the comment: what does "preserved from any salvage debug use" mean?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158171/new/

https://reviews.llvm.org/D158171