[PATCH] D157502: [LoopPredication] Rework assumes of widened conditions

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 09:38:01 PDT 2023


anna accepted this revision.
anna added a comment.
This revision is now accepted and ready to land.

LGTM w/ comments.



================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:758
 
-unsigned LoopPredication::widenChecks(SmallVectorImpl<Value *> &Checks,
-                                      SCEVExpander &Expander,
-                                      Instruction *Guard) {
-  unsigned NumWidened = 0;
+void widenChecks(SmallVectorImpl<Value *> &Checks,
+                 SmallVectorImpl<Value *> &WidenedChecks,
----------------



================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:776
   SmallVector<Value *, 4> Checks;
+  SmallVector<Value *, 4> WidenedChecks;
   parseWidenableGuard(Guard, Checks);
----------------



================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:813
   SmallVector<Value *, 4> Checks;
+  SmallVector<Value *, 4> WidenedChecks;
   parseWidenableGuard(BI, Checks);
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157502/new/

https://reviews.llvm.org/D157502



More information about the llvm-commits mailing list