[PATCH] D157872: [SelectionDAG] Use TypeSize variant of ComputeValueVTs to compute correct offsets for scalable aggregate types.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D157872#4595092 <https://reviews.llvm.org/D157872#4595092>, @paulwalker-arm wrote:

> In D157872#4592711 <https://reviews.llvm.org/D157872#4592711>, @craig.topper wrote:
>
>> Should we backport this to LLVM 17?
>
> I wasn't sure of the relative importance given the original work landed prior to LLVM 16.  For AArch64 there's no significant need, I only discovered the bug due to some follow on work that I'm hoping to make public soon.
>
> That said, I've just tried and the patches don't just cherry-pick so if you think this is something you're likely to hit for LLVM 17 just let me know and I'll try the branch route given I guess I'll need to learn how pull request work anyway :)

Wasn't the code added in March 2023? That would have been after LLVM 16 branched.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157872/new/

https://reviews.llvm.org/D157872