[PATCH] D158073: [llvm-jitlink] Add target override option to cli

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz accepted this revision.
sgraenitz added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM. Yes let's keep this on hold for now and attempt the `RuntimeDyldChecker` change first.



================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink.cpp:2005
 
+  // Infer the target, if triple is given by user override TT
   auto [TT, Features] = getFirstFileTripleAndFeatures();
----------------
The comment is easy to misunderstand. Can we swap the phrase like this?
```
Infer the target and override TT if triple is given by user 
```


================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink.cpp:2007
   auto [TT, Features] = getFirstFileTripleAndFeatures();
+  if(TripleName != ""){
+    TT = Triple(Triple::normalize(TripleName));
----------------
Please run this through a `git clang-format HEAD^`? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158073/new/

https://reviews.llvm.org/D158073