[PATCH] D157712: [AMDGPU] Autogenerate & pre-commit tests for D156301 and D157388

[Pravin Jagtap via Phabricator via llvm-commits]

pravinjagtap marked an inline comment as not done.
pravinjagtap added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/global_atomic_optimizer_fp_rtn.ll:136
+
+define amdgpu_ps float @global_atomic_fadd_uni_value_scope_defalut(ptr addrspace(1) inreg %ptr, float inreg %val) #2 {
+; IR-ITERATIVE-LABEL: @global_atomic_fadd_uni_value_scope_defalut(
----------------
arsenm wrote:
> pravinjagtap wrote:
> > arsenm wrote:
> > > should be a separate strictfp test, the strictfp is hidden
> > These atomicrmw operations are tested with following attributes and there is separate attribute for `strictfp` which is #2
> > 
> > ```
> > attributes #0 = { "denormal-fp-math-f32"="preserve-sign,preserve-sign" "amdgpu-unsafe-fp-atomics"="true" }
> > attributes #1 = { strictfp "denormal-fp-math-f32"="preserve-sign,preserve-sign" "amdgpu-unsafe-fp-atomics"="true" }
> > attributes #2 = { strictfp}
> > ```
> Which is the function I pointed to, marked with attribute group 2. The test name does not indicate this is a strictfp test and it looks like it's just testing the other combinations of uniformity and scope
you want me to mangle the attributes into function name for each of them? And Yes, these tests are the combination of fadd/fsub/fmin/fmax with different scopes and also combination of uniform or divergent input values to atomicrmw (address and value). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157712/new/

https://reviews.llvm.org/D157712