[PATCH] D133926: [DebugInfo] Allow non-stack_value variadic expressions and use in DBG_INSTR_REF

[Felipe de Azevedo Piovezan via Phabricator via llvm-commits]

fdeazeve added a comment.

In D133926#4594914 <https://reviews.llvm.org/D133926#4594914>, @StephenTozer wrote:

> In D133926#4592629 <https://reviews.llvm.org/D133926#4592629>, @fdeazeve wrote:
>
>> Because of this, we end up calling `DwarfExpression::addExpression`, which crashes for that example because it doesn't expect an entry value.
>
> Thanks for the further details - in summary, as part of the changes to DBG_INSTR_REF, we started using the variadic syntax for debug values that would normally have been non-variadic - there's no fundamental problem with this, but clearly some edges weren't fully ironed out. I'll submit a patch shortly with a fix - do you have a reproducer for the issue?

Yup, that makes perfect sense. Let me see if I can conjure a min repro and I'll come back here shortly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133926/new/

https://reviews.llvm.org/D133926