[PATCH] D156413: [AMDGPU][PEI] Set up SP for chain functions

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 03:58:52 PDT 2023


rovka updated this revision to Diff 551082.
rovka added a comment.

Use requiresStackPointerReference. We still need to check hasStackObjects though, otherwise we end up using an uninitialized s32 for spills and allocas. Ideally we'd be able to use an immediate for those cases, but I haven't figured out how to do that yet, so I left a FIXME.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156413/new/

https://reviews.llvm.org/D156413

Files:
  llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
  llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
  llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-cc.ll
  llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-preserve-cc.ll
  llvm/test/CodeGen/AMDGPU/pei-amdgpu-cs-chain-preserve.mir
  llvm/test/CodeGen/AMDGPU/pei-amdgpu-cs-chain.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156413.551082.patch
Type: text/x-patch
Size: 30244 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230817/390a5342/attachment.bin>


More information about the llvm-commits mailing list