[PATCH] D158115: [SelectionDAG][RISCV][SVE] Harden fixed offset version of ComputeValueVTs against scalable offsets.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.
Herald added a subscriber: sunshaoce.


================
Comment at: llvm/lib/CodeGen/Analysis.cpp:151
-    for (TypeSize Offset : Offsets)
-      FixedOffsets->push_back(Offset.getKnownMinValue());
 }
----------------
A value of zero is both fixed and scalable compatible so I think perhaps this should just always be `getFixedValue()` and `TypeSize` should be updated to allow the scalable zero case to return 0.

I also think `isFixed()` and `isScalable()` should return true for the zero case but that can be a job for later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158115/new/

https://reviews.llvm.org/D158115