[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:1
+//===-------- RISCVInstrInfoZicfiss.td - RISC-V CFG -*- tablegen -*--------===//
+//
----------------
CFG?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:48-49
+let Uses = [SSP], hasSideEffects = 0, mayLoad = 1, mayStore = 0 in {
+def SSLOAD :
+  RVInstI<0b100, OPC_SYSTEM, (outs GPRRA:$rd), (ins), "ssload", "$rd"> {
+  let rs1 = 0;
----------------
This is some strange wrapping; normally we'd put RVInstI on the same line and wrap some of the arguments, but if you really want to wrap then indent by 4 spaces and put the colon on the lower line, that's what the predominant style is


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:62
+let Uses = [SSP], hasSideEffects = 0, mayLoad = 0, mayStore = 0 in {
+def SSPINC : RVInstI<0b100, OPC_SYSTEM, (outs), (ins uimm5nonzero:$rs1),
+                     "sspinc", "$rs1"> {
----------------
This is how I'd expect the earlier instructions to be formatted, FWIW... please be consistent


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:94
+def C_SSPOPCHK : RVC_SSInst<0b00101, GPRX5, "c.sspopchk">;
+}// Predicates = [HasStdExtZicfiss, HasStdExtC]
----------------
Missing space


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152793/new/

https://reviews.llvm.org/D152793