[PATCH] D157712: [AMDGPU] Autogenerate & pre-commit tests for D156301 and D157388

[Pravin Jagtap via Phabricator via llvm-commits]

pravinjagtap added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/global_atomic_optimizer_fp_rtn.ll:136
+
+define amdgpu_ps float @global_atomic_fadd_uni_value_scope_defalut(ptr addrspace(1) inreg %ptr, float inreg %val) #2 {
+; IR-ITERATIVE-LABEL: @global_atomic_fadd_uni_value_scope_defalut(
----------------
arsenm wrote:
> should be a separate strictfp test, the strictfp is hidden
These atomicrmw operations are tested with following attributes and there is separate attribute for `strictfp` which is #2

```
attributes #0 = { "denormal-fp-math-f32"="preserve-sign,preserve-sign" "amdgpu-unsafe-fp-atomics"="true" }
attributes #1 = { strictfp "denormal-fp-math-f32"="preserve-sign,preserve-sign" "amdgpu-unsafe-fp-atomics"="true" }
attributes #2 = { strictfp}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157712/new/

https://reviews.llvm.org/D157712