[PATCH] D157655: [Mips] AttemptToFoldSymbolOffsetDifference: revert isMicroMips special case

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 20:47:41 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/Mips/micromips-b-range.ll:16
 ; CHECK-NEXT:    26:	40 60 00 02 	bal	0x2e <foo+0x2e>
-; CHECK-NEXT:    2a:	30 21 04 69 	addiu	$1, $1, 1129
+; CHECK-NEXT:    2a:	30 21 04 68 	addiu	$1, $1, 1128
 ; CHECK-NEXT:    2e:	00 3f 09 50 	addu	$1, $ra, $1
----------------
I left a comment to https://reviews.llvm.org/D57677#4594051 . I am now more certain that the micromips .gcc_except_table is wrong and harmful and I am going to land this revert.

Nobody has noticed an issue likely because micromips support is quite poor in llvm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157655/new/

https://reviews.llvm.org/D157655



More information about the llvm-commits mailing list