[PATCH] D57677: [mips][micromips] Fix values in .gcc_except_table for -fPIC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 20:46:03 PDT 2023


MaskRay added inline comments.
Herald added a project: All.


================
Comment at: llvm/trunk/test/CodeGen/Mips/micromips-b-range.ll:16
 ; CHECK-NEXT:    26:	40 60 00 02 	bal	8 <foo+0x2e>
-; CHECK-NEXT:    2a:	30 21 04 68 	addiu	$1, $1, 1128
+; CHECK-NEXT:    2a:	30 21 04 69 	addiu	$1, $1, 1129
 ; CHECK-NEXT:    2e:	00 3f 09 50 	addu	$1, $ra, $1
----------------
Changes to this file seem wrong. I have produced an assembly file and assembled it with `mipsel-linux-gnu-gcc -mmicromips`. The values are even.

Apologies, but I am going to revert the MCExpr.cpp change in D157655. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57677/new/

https://reviews.llvm.org/D57677



More information about the llvm-commits mailing list