[PATCH] D156283: MIPS: unwind, don't save/restore hi/lo for R6

YunQiang Su via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 18:21:48 PDT 2023


wzssyqa added a comment.

In D156283#4590543 <https://reviews.llvm.org/D156283#4590543>, @MaskRay wrote:

> In D156283#4590529 <https://reviews.llvm.org/D156283#4590529>, @wzssyqa wrote:
>
>> In D156283#4589972 <https://reviews.llvm.org/D156283#4589972>, @MaskRay wrote:
>>
>>>> wzssyqa removed a reviewer: libunwind.
>>>
>>> Some projects like libc++/libc++abi/libunwind add a default reviewer group. This ensures #libunwind <https://reviews.llvm.org/tag/libunwind/> people know changes going into libunwind. They may not comment, but they can do so when a change increasing maintenance burden catches their eye.
>>
>> I added libunwind group back.
>> It was "blocking libunwind" previous. I have no idea what it means?
>
> Someone in the #libunwind <https://reviews.llvm.org/tag/libunwind/> needs to click `Accept as libunwind` to make the differential green, otherwise it is in the `Needs Review` state even if there is an approval.

How can I ping the #libunwind <https://reviews.llvm.org/tag/libunwind/> group?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156283/new/

https://reviews.llvm.org/D156283



More information about the llvm-commits mailing list