[PATCH] D157177: [Coroutine][DebugInfo] Pre-commit test for a DISubprogram with declaration.

[DianQK via Phabricator via llvm-commits]

DianQK added inline comments.


================
Comment at: llvm/test/Transforms/Coroutines/coro-async-declaration.ll:1
+; RUN: opt < %s -passes='default<O2>' -S | FileCheck %s
+
----------------
fdeazeve wrote:
> Running the entirety of O2 is not ideal for a Transform test, see for example `llvm/test/Transforms/Coroutines/swift-async-dbg.ll`.
> 
> Please also note that a lot of lines in this test are not needed to exercise the behaviour we want to preserve in the subsequent commit
Thank you. I also thought the test was too big. The original version was actually bigger and I tried to remove irrelevant parts of the test.
May I ask how your test was created? Where is the source code? I guess I could just add a struct to it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157177/new/

https://reviews.llvm.org/D157177