[PATCH] D158108: [CoroSplit][DebugInfo] Don't use entry_value in coroutine entry point

Felipe de Azevedo Piovezan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 14:52:50 PDT 2023


fdeazeve added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1884
           // This dbg.declare is for the main function entry point.  It
           // will be deleted in all coro-split functions.
+          coro::salvageDebugInfo(ArgToAllocaMap, DDI, Shape.OptimizeFrame,
----------------
aprantl wrote:
> And I assume that the "it will be deleted in all other funclets" guarantee still holds for the non-entry-value dbg.declare?
Yup, that deletion seems to be unconditional!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158108/new/

https://reviews.llvm.org/D158108



More information about the llvm-commits mailing list